linux-kernel - Re: rtlwifi: fix error handling in *_read_adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160616151351.4AD026141C@smtp.codeaurora.org>
Date:	Thu, 16 Jun 2016 15:13:51 +0000 (UTC)
From:	Kalle Valo <kvalo@...eaurora.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Larry Finger <Larry.Finger@...inger.net>,
	Arnd Bergmann <arnd@...db.de>,
	Chaoming Li <chaoming_li@...lsil.com.cn>,
	Taehee Yoo <ap420073@...il.com>,
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: rtlwifi: fix error handling in *_read_adapter_info()

Arnd Bergmann <arnd@...db.de> wrote:
> There are nine copies of the _rtl88ee_read_adapter_info() function,
> and most but not all of them cause a build warning in some configurations:
> 
> rtl8192de/hw.c: In function '_rtl92de_read_adapter_info':
> rtl8192de/hw.c:1767:12: error: 'hwinfo' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> rtl8723ae/hw.c: In function '_rtl8723e_read_adapter_info.constprop':
> rtlwifi/rtl8723ae/hw.c:1654:12: error: 'hwinfo' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> 
> The problem is that when rtlefuse->epromtype is something other than
> EEPROM_BOOT_EFUSE, the rest of the function uses undefined data, resulting
> in random behavior later.
> 
> Apparently, in some drivers, the problem was already found and fixed
> but the fix did not make it into the others.
> 
> This picks one approach to deal with the problem and applies identical
> code to all 9 files, to simplify the later consolidation of those.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Acked-by: Larry Finger <Larry.Finger@...inger.net>

Thanks, 1 patch applied to wireless-drivers-next.git:

5345ea6a4bfb rtlwifi: fix error handling in *_read_adapter_info()

-- 
Sent by pwcli
https://patchwork.kernel.org/patch/9141721/