linux-kernel - Re: [v3,1/2] b43: Remove unused phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y465unz5.fsf@kamboji.qca.qualcomm.com>
Date:	Thu, 16 Jun 2016 18:56:14 +0300
From:	Kalle Valo <kvalo@...eaurora.org>
To:	Michael Büsch <m@...s.ch>
Cc:	Guenter Roeck <linux@...ck-us.net>, netdev@...r.kernel.org,
	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
	b43-dev@...ts.infradead.org
Subject: Re: [v3,1/2] b43: Remove unused phy_a code

Michael Büsch <m@...s.ch> writes:

> On Thu, 16 Jun 2016 15:23:37 +0000 (UTC)
> Kalle Valo <kvalo@...eaurora.org> wrote:
>
>> Guenter Roeck <linux@...ck-us.net> wrote:
>> > gcc-6 reports the following error with -Werror=unused-const-variable.
>> > 
>> > drivers/net/wireless/broadcom/b43/phy_a.c:576:40: error:
>> > 	'b43_phyops_a' defined but not used
>> > 
>> > Per Michael Büsch: "All a-phy code is usused", so remove it all,
>> > and move the remaining Type-G initialization code into phy_g.c.
>> > 
>> > Reported-by: Fengguang Wu <fengguang.wu@...el.com> [0-day test robot]
>> > Cc: Michael Büsch <m@...s.ch>
>> > Signed-off-by: Guenter Roeck <linux@...ck-us.net>  
>> 
>> Thanks, 2 patches applied to wireless-drivers-next.git:
>> 
>> 9791333a840f b43: Remove unused phy_a code
>> afdfdc481ea9 b43: Completely remove support for phy_a
>
> Did anybody test this on any hardware? I think this should be tested
> on some G-PHY hardware, before it goes to Linus.

Larry tested these:

"These two patches have been tested on a BCM4318."

https://patchwork.kernel.org/patch/9154719/

-- 
Kalle Valo