linux-kernel - Re: [PATCH RFC 0/3] perf script: Add callindent option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160616163745.GC13337@kernel.org>
Date:	Thu, 16 Jun 2016 13:37:45 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	Adrian Hunter <adrian.hunter@...el.com>,
	Jiri Olsa <jolsa@...hat.com>, linux-kernel@...r.kernel.org,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH RFC 0/3] perf script: Add callindent option

Em Thu, Jun 16, 2016 at 03:34:31PM +0300, Adrian Hunter escreveu:
> Hi
> 
> Andi Kleen sent a couple of patches to add a callindent option to
> perf script. If Andi is agreeable, I would like to propose an
> alternative implementation.

Andi?

- Arnaldo
 
> While there are some differences in the resulting output, the main
> differences are:
> 
>  1. Tell the decoder to feed branches to the thread stack, which has the
>  advantage that it happens before branch filtering and so can be used
>  with different itrace options (e.g. it still works when only showing
>  calls, even though the thread stack needs to see calls and returns). Also
>  it does not conflict with using the thread stack to get callchains.
> 
>  2. Print "call" or "ret" instead of using a different event
> 
> 
> Adrian Hunter (3):
>       perf: script: Fix documentation of '-f' when it should be '-F'
>       perf auxtrace: Add option to feed branches to the thread stack
>       perf script: Add callindent option
> 
>  tools/perf/Documentation/perf-script.txt | 26 +++++++-----
>  tools/perf/builtin-script.c              | 70 ++++++++++++++++++++++++++++++++
>  tools/perf/util/auxtrace.h               |  2 +
>  tools/perf/util/intel-bts.c              | 22 +++++++---
>  tools/perf/util/intel-pt.c               |  5 ++-
>  tools/perf/util/thread-stack.c           |  7 ++++
>  tools/perf/util/thread-stack.h           |  1 +
>  7 files changed, 117 insertions(+), 16 deletions(-)
> 
> 
> Regards
> Adrian