linux-kernel - Re: linux-next: Tree for Jun 16 (linux/firmware.h)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <146610076777.8942.6261908779926362192@sboyd-linaro>
Date:	Thu, 16 Jun 2016 11:12:47 -0700
From:	Stephen Boyd <stephen.boyd@...aro.org>
To:	Randy Dunlap <rdunlap@...radead.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org,
	"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
	"Stephen Rothwell" <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org
Subject: Re: linux-next: Tree for Jun 16 (linux/firmware.h)

Quoting Randy Dunlap (2016-06-16 09:46:43)
> [adding Stephen Boyd]
> 
> On 06/16/16 08:02, Randy Dunlap wrote:
> > On 06/15/16 22:49, Stephen Rothwell wrote:
> >> Hi all,
> >>
> >> Changes since 20160615:
> >>
> > 
> > on i386 and/or x86_64:
> > 
> > In file included from ../drivers/fpga/fpga-mgr.c:21:0:
> > ../include/linux/firmware.h:82:1: error: expected identifier or ( before { token
> >  {
> >  ^
> > 
> > 
> 
> See:
> 
> static inline int request_firmware_into_buf(const struct firmware **firmware_p,
>         const char *name, struct device *device, void *buf, size_t size);
> {
>         return -EINVAL;
> }
> 

Urgh sorry about that. The semicolon should go away. Andrew can you
squash this in? I tested compilation without this config enabled.

---8<---
diff --git a/include/linux/firmware.h b/include/linux/firmware.h
index bdc24ee92823..b1f9f0ccb8ac 100644
--- a/include/linux/firmware.h
+++ b/include/linux/firmware.h
@@ -78,7 +78,7 @@ static inline int request_firmware_direct(const struct firmware **fw,
 }
 
 static inline int request_firmware_into_buf(const struct firmware **firmware_p,
-	const char *name, struct device *device, void *buf, size_t size);
+	const char *name, struct device *device, void *buf, size_t size)
 {
 	return -EINVAL;
 }