linux-kernel - Re: [PATCH] net: sfc: avoid -Wtype-limits warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160616.142424.302149364592568497.davem@davemloft.net>
Date:	Thu, 16 Jun 2016 14:24:24 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	arnd@...db.de
Cc:	linux-net-drivers@...arflare.com, ecree@...arflare.com,
	bkenward@...arflare.com, mhabets@...arflare.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: sfc: avoid -Wtype-limits warning

From: Arnd Bergmann <arnd@...db.de>
Date: Wed, 15 Jun 2016 22:31:10 +0200

> When building with -Wextra, we get a harmless warning from the
> EFX_EXTRACT_OWORD32 macro:
> 
> ethernet/sfc/farch.c: In function 'efx_farch_test_registers':
> ethernet/sfc/farch.c:119:30: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
> ethernet/sfc/farch.c:124:144: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
> ethernet/sfc/farch.c:124:392: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
> ethernet/sfc/farch.c:124:731: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
> 
> The macro and the caller are both correct, but we can avoid the
> warning by changing the index variable to a signed type.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied, thanks.