[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1614232.pce5aJ6WZ3@phil>
Date: Fri, 17 Jun 2016 01:36:45 +0200
From: Heiko Stuebner <heiko@...ech.de>
To: Brian Norris <briannorris@...omium.org>
Cc: Kishon Vijay Abraham I <kishon@...com>,
linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org,
Doug Anderson <dianders@...omium.org>,
Shawn Lin <shawn.lin@...k-chips.com>,
linux-arm-kernel@...ts.infradead.org,
Brian Norris <computersforpeace@...il.com>
Subject: Re: [PATCH 3/4] phy: rockchip-emmc: configure default output tap delay
Am Donnerstag, 12. Mai 2016, 15:43:05 schrieb Brian Norris:
> The output tap delay controls helps maintain the hold requirements for
> eMMC. The exact value is dependent on the SoC and other factors, though
> it isn't really an exact science. But the default of 0 is not very good,
> as it doesn't give the eMMC much hold time, so let's bump up to 4
> (approx 90 degree phase?). If we need to configure this any further
> (e.g., based on board or speed factors), we may need to consider a
> device tree representation.
>
> Suggested-by: Shawn Lin <shawn.lin@...k-chips.com>
> Signed-off-by: Brian Norris <briannorris@...omium.org>
on my rk3399-evb board the emmc still runs nicely with this patch, so
Tested-by: Heiko Stuebner <heiko@...ech.de>
Powered by blists - more mailing lists