linux-kernel - Re: [PATCH v2.1 07/11] mmc: sdhci-of-arasan: Add ability to export card clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2078624.p3pqVZlzC3@phil>
Date:	Fri, 17 Jun 2016 01:54:54 +0200
From:	Heiko Stuebner <heiko@...ech.de>
To:	Douglas Anderson <dianders@...omium.org>
Cc:	ulf.hansson@...aro.org, kishon@...com, robh+dt@...nel.org,
	shawn.lin@...k-chips.com, xzy.xu@...k-chips.com,
	briannorris@...omium.org, adrian.hunter@...el.com,
	linux-rockchip@...ts.infradead.org, linux-mmc@...r.kernel.org,
	devicetree@...r.kernel.org, groeck@...omium.org,
	michal.simek@...inx.com, soren.brinkmann@...inx.com,
	geert@...ux-m68k.org, wsa+renesas@...g-engineering.com,
	swarren@...dotorg.org, stefan.wahren@...e.com,
	luisbg@....samsung.com, andrei.pistirica@...rochip.com,
	chaotian.jing@...iatek.com, ludovic.desroches@...el.com,
	yangbo.lu@...escale.com, horms+renesas@...ge.net.au,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2.1 07/11] mmc: sdhci-of-arasan: Add ability to export card clock

Am Mittwoch, 15. Juni 2016, 09:37:51 schrieb Douglas Anderson:
> Some SD/eMMC PHYs (like the PHY from Arasan that is designed to work
> with arasan,sdhci-5.1) need to know the card clock in order to function
> properly.  Let's add the ability to expose this clock.  Any PHY that
> needs to know the clock rate can add a reference and query the clock
> rate.
> 
> At the moment we register a CLK_GET_RATE_NOCACHE clock that simply
> allows querying the clock.  This allows us to be less intrusive with
> regards to the main SDHCI driver, which has complex logic for adjusting
> the SD clock.  Right now we always fully power cycle the PHY when the
> clock changes and that gives the PHY a good chance to query our clock.
> 
> Signed-off-by: Douglas Anderson <dianders@...omium.org>

for me this looks very nice implementation-wise and I also didn't spot 
glaring things, so
Reviewed-by: Heiko Stuebner <heiko@...ech.de>

and as states in the original series, on a rk3399-evb
Tested-by: Heiko Stuebner <heiko@...ech.de>