linux-kernel - Re: [PATCH v3 5/7] max8903: removes non zero validity checks on gpios.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <57639A3F.90607@samsung.com>
Date:	Fri, 17 Jun 2016 08:35:43 +0200
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Chris Lapa <chris@...a.com.au>, dwmw2@...radead.org,
	dbaryshkov@...il.com, sre@...nel.org, mark.rutland@....com,
	robh+dt@...nel.org
Cc:	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-pm@...r.kernel.org
Subject: Re: [PATCH v3 5/7] max8903: removes non zero validity checks on gpios.

On 06/17/2016 07:00 AM, Chris Lapa wrote:
> From: Chris Lapa <chris@...a.com.au>
> 
> Prior to this commit a zero gpio was treated as invalid. Whereas
> gpio_is_valid() will treat a zero gpio as valid.
> 
> This commit removes the confusion and explicity uses gpio_is_valid()

s/explicity/explicitly/

> throughout. Which in turn results in several of the error messages becoming
> redundant and thus removed.
> 
> Signed-off-by: Chris Lapa <chris@...a.com.au>
> ---
>  drivers/power/max8903_charger.c | 125 ++++++++++++++++++----------------------
>  1 file changed, 55 insertions(+), 70 deletions(-)

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>

Best regards,
Krzysztof