linux-kernel - Re: [RFC] [PATCH 0/3] media: an attempt to refresh omap1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5763A114.2080309@xs4all.nl>
Date:	Fri, 17 Jun 2016 09:04:52 +0200
From:	Hans Verkuil <hverkuil@...all.nl>
To:	Janusz Krzysztofik <jmkrzyszt@...il.com>,
	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Guennadi Liakhovetski <g.liakhovetski@....de>,
	Amitoj Kaur Chawla <amitoj1606@...il.com>,
	Arnd Bergmann <arnd@...db.de>,
	Tony Lindgren <tony@...mide.com>, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-omap@...r.kernel.org
Subject: Re: [RFC] [PATCH 0/3] media: an attempt to refresh omap1_camera
 driver

Hi Janusz,

On 06/16/2016 07:21 PM, Janusz Krzysztofik wrote:
> As requested by media subsystem maintainers, here is an attempt to 
> convert the omap1_camera driver to the vb2 framework. Also, conversion 
> to the dmaengine framework, long awaited by ARM/OMAP maintainers, is 
> done.
> 
> Next, I'm going to approach removal of soc-camera dependency. Please 
> let me know how much time I have for that, i.e., when the soc-camera
> framework is going to be depreciated.

Well, it is already deprecated (i.e. new drivers cannot use it), but it won't
be removed any time soon. There are still drivers depending on it, and some
aren't easy to rewrite.

I have to say that it is totally unexpected to see that this omap1 driver is still
used. In fact, we've already merged a patch that removed it for the upcoming
4.8 kernel. Based on this new development I'll revert that for the omap1
driver.

Out of curiosity: is supporting the Amstrad Delta something you do as a hobby
or are there other reasons?

A final note: once you've managed to drop the soc-camera dependency you should
run the v4l2-compliance test over the video node (https://git.linuxtv.org/v4l-utils.git/).

If that passes without failures, then this driver is in good shape and can be
moved out of staging again.

Regards,

	Hans

> 
> Thanks,
> Janusz
> 
> 
> Janusz Krzysztofik (3):
>   staging: media: omap1: drop videobuf-dma-sg mode
>   staging: media: omap1: convert to videobuf2
>   staging: media: omap1: use dmaengine
> 
>  drivers/staging/media/omap1/Kconfig              |   5 +-
>  drivers/staging/media/omap1/omap1_camera.c       | 948 +++++------------------
>  include/linux/platform_data/media/omap1_camera.h |   9 -
>  3 files changed, 217 insertions(+), 745 deletions(-)
>