linux-kernel - Re: [PATCH v10 00/14] USB OTG/dual-role framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 17 Jun 2016 10:31:52 +0300
From:	Roger Quadros <rogerq@...com>
To:	Felipe Balbi <balbi@...nel.org>
CC:	<peter.chen@...escale.com>, <tony@...mide.com>,
	<gregkh@...uxfoundation.org>, <dan.j.williams@...el.com>,
	<mathias.nyman@...ux.intel.com>, <Joao.Pinto@...opsys.com>,
	<sergei.shtylyov@...entembedded.com>, <jun.li@...escale.com>,
	<grygorii.strashko@...com>, <yoshihiro.shimoda.uh@...esas.com>,
	<robh@...nel.org>, <nsekhar@...com>, <b-liu@...com>,
	<joe@...ches.com>, <linux-usb@...r.kernel.org>,
	<linux-omap@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<devicetree@...r.kernel.org>
Subject: Re: [PATCH v10 00/14] USB OTG/dual-role framework

On 17/06/16 10:17, Felipe Balbi wrote:
> 
> Hi Roger,
> 
> Roger Quadros <rogerq@...com> writes:
>>> This series centralizes OTG/Dual-role functionality in the kernel.
>>> As of now I've got Dual-role functionality working pretty reliably on
>>> dra7-evm and am437x-gp-evm.
>>
>> Do you have any comments on this series? If yes I can include them
>> before sending v11 with Acks from Peter and Alan. Thanks.
> 
> I'll need some more time to look at this, have been real busy with some
> internal tasks. Frankly, though, I still think this is way more complex
> than what it needs to be and that's actually quite scary IMO.
> 
> I'll try to dedicate some time today to review these patches, hopefully
> I'll find a few minutes. I know that I also owe you a look at the IRQ
> cleanup for dwc3, I'll see if I can get to that as well.
> 

Thanks Felipe. I'm definitely open to improve this in whatever way
we can so that individual controller drivers prefer to use it than
do their own thing. A bit earlier review would have helped to avoid unnecessary
rework but let's do it now than never. :)

cheers,
-roger



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)