linux-kernel - [PATCH] Make COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1466152995-28367-1-git-send-email-richard@nod.at>
Date:	Fri, 17 Jun 2016 10:43:15 +0200
From:	Richard Weinberger <richard@....at>
To:	akpm@...ux-foundation.org
Cc:	dhowells@...hat.com, David.Woodhouse@...el.com, hannes@...xchg.org,
	tj@...nel.org, ard.biesheuvel@...aro.org, pmladek@...e.com,
	rusty@...tcorp.com.au, arnd@...db.de, linux-kernel@...r.kernel.org,
	Richard Weinberger <richard@....at>,
	Al Viro <viro@...iv.linux.org.uk>
Subject: [PATCH] Make COMPILE_TEST depend on !UML

UML is a bit special since it does not have iomem nor dma.
That means a lot of drivers will not build if they miss a
dependency on HAS_IOMEM. s390 used to have the same issues
but since it gained PCI support UML is the only stranger.

We are tired of patching dozens of new drivers after every
merge window just to un-break allmod/yesconfig UML builds.
One could argue that a decent driver has to know on what
it depends and therefore a missing HAS_IOMEM dependency is
a clear driver bug. But the dependency not obvious and not
everyone does UML builds with COMPILE_TEST enabled when
developing a device driver.

A possible solution to make these builds succeed on UML
would be providing stub functions for ioremap() and friends
which fail upon runtime. Another one is simply disabling
COMPILE_TEST for UML. Since it is the least hassle and does
not force use to fake iomem support let's do the latter.

Cc: Al Viro <viro@...iv.linux.org.uk>
Acked-by: Arnd Bergmann <arnd@...db.de>
Signed-off-by: Richard Weinberger <richard@....at>
---
 init/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/init/Kconfig b/init/Kconfig
index f755a60..eae1808 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -55,6 +55,7 @@ config CROSS_COMPILE

 config COMPILE_TEST
 	bool "Compile also drivers which will not load"
+	depends on !UML
 	default n
 	help
 	  Some drivers can be compiled on a different platform than they are
-- 
2.7.3