linux-kernel - Re: [PATCH] MIPS: Lantiq: fix build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <224d637f-70b6-f8cc-0c68-c3e51d538906@phrozen.org>
Date:	Fri, 17 Jun 2016 10:46:43 +0200
From:	John Crispin <john@...ozen.org>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	Ralf Baechle <ralf@...ux-mips.org>
Cc:	linux-kernel@...r.kernel.org, linux-mips@...ux-mips.org
Subject: Re: [PATCH] MIPS: Lantiq: fix build failure



On 16/06/2016 22:46, Sudip Mukherjee wrote:
> Some configs of mips like xway_defconffig are failing with the error:
> arch/mips/lantiq/irq.c:209:2: error: initialization from incompatible
> pointer type [-Werror]
>   "icu",
>   ^
> arch/mips/lantiq/irq.c:209:2: error: (near initialization for
> 'ltq_irq_type.parent_device') [-Werror]
> arch/mips/lantiq/irq.c:219:2: error: initialization from incompatible
> pointer type [-Werror]
>   "eiu",
>   ^
> arch/mips/lantiq/irq.c:219:2: error: (near initialization for
> 'ltq_eiu_type.parent_device') [-Werror]
> 
> The first member of the "struct irq" is no longer a pointer for the
> name.
> 
> Fixes: be45beb2df69 ("genirq: Add runtime power management support for IRQ chips")
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>

Acked-by: John Crispin <john@...ozen.org>

> ---
> 
> build log can be seen at:
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/137992701
> 
>  arch/mips/lantiq/irq.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/mips/lantiq/irq.c b/arch/mips/lantiq/irq.c
> index ff17669e..02c0252 100644
> --- a/arch/mips/lantiq/irq.c
> +++ b/arch/mips/lantiq/irq.c
> @@ -206,7 +206,7 @@ static void ltq_shutdown_eiu_irq(struct irq_data *d)
>  }
>  
>  static struct irq_chip ltq_irq_type = {
> -	"icu",
> +	.name = "icu",
>  	.irq_enable = ltq_enable_irq,
>  	.irq_disable = ltq_disable_irq,
>  	.irq_unmask = ltq_enable_irq,
> @@ -216,7 +216,7 @@ static struct irq_chip ltq_irq_type = {
>  };
>  
>  static struct irq_chip ltq_eiu_type = {
> -	"eiu",
> +	.name = "eiu",
>  	.irq_startup = ltq_startup_eiu_irq,
>  	.irq_shutdown = ltq_shutdown_eiu_irq,
>  	.irq_enable = ltq_enable_irq,
>