linux-kernel - Re: [PATCH v10 0/8] add i2c driver supported for rk3399

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160617115611.GC6876@tetsubishi>
Date:	Fri, 17 Jun 2016 13:56:11 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	David Wu <david.wu@...k-chips.com>
Cc:	heiko@...ech.de, robh+dt@...nel.org, dianders@...omium.org,
	andy.shevchenko@...il.com, pawel.moll@....com,
	mark.rutland@....com, ijc+devicetree@...lion.org.uk,
	galak@...eaurora.org, briannorris@...gle.com,
	davidriley@...gle.com, huangtao@...k-chips.com, hl@...k-chips.com,
	xjq@...k-chips.com, zyw@...k-chips.com, cf@...k-chips.com,
	linux-arm-kernel@...ts.infradead.org,
	linux-rockchip@...ts.infradead.org, linux-i2c@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v10 0/8] add i2c driver supported for rk3399

On Mon, May 16, 2016 at 09:57:35PM +0800, David Wu wrote:
> There are three points differert from others:
>  - new method to caculate i2c timings for rk3399
>  - pclk and function clk are separated at rk3399
>  - add fast-plus mode supported for rk3399
> 
> David Wu (8):
>   i2c: rk3x: add documentation to fields in "struct rk3x_i2c"
>   i2c: rk3x: use struct "rk3x_i2c_calced_timings"
>   i2c: rk3x: Remove redundant rk3x_i2c_clean_ipd()
>   i2c: rk3x: Change SoC data to not use array
>   i2c: rk3x: Move spec timing data to "static const" structs
>   dt-bindings: i2c: rk3x: add support for rk3399
>   i2c: rk3x: add i2c support for rk3399 soc
>   i2c: rk3x: support fast-mode plus for rk3399
> 
>  Documentation/devicetree/bindings/i2c/i2c-rk3x.txt |  16 +-

Applied whole series to for-next, thanks! This was nicely refactored and
easy to review, thanks. Also thanks to all reviewers who helped this
series. I fixed one checkpatch issue for you, though:

WARNING: Statements should start on a tabstop
#278: FILE: drivers/i2c/busses/i2c-rk3x.c:789:
+	 if (min_div_for_hold >= min_total_div) {


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)