linux-kernel - Re: [PATCH v9 09/22] IB/hns: Add hca support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57635269.3030905@huawei.com>
Date:	Fri, 17 Jun 2016 09:29:13 +0800
From:	"Wei Hu (Xavier)" <xavier.huwei@...wei.com>
To:	<leon@...nel.org>, Lijun Ou <oulijun@...wei.com>
CC:	<dledford@...hat.com>, <sean.hefty@...el.com>,
	<hal.rosenstock@...il.com>, <davem@...emloft.net>,
	<jeffrey.t.kirsher@...el.com>, <jiri@...lanox.com>,
	<ogerlitz@...lanox.com>, <linux-rdma@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
	<gongyangming@...wei.com>, <xiaokun@...wei.com>,
	<tangchaofei@...wei.com>, <haifeng.wei@...wei.com>,
	<yisen.zhuang@...wei.com>, <yankejian@...wei.com>,
	<charles.chenxin@...wei.com>, <linuxarm@...wei.com>
Subject: Re: [PATCH v9 09/22] IB/hns: Add hca support



On 2016/6/9 15:10, Leon Romanovsky wrote:
> On Wed, Jun 01, 2016 at 11:37:51PM +0800, Lijun Ou wrote:
>> This patch mainly setup hca for RoCE. It will do a series of
>> initial works, as follows:
>>      1. init uar table, allocate uar resource
>>      2. init pd table
>>      3. init cq table
>>      4. init mr table
>>      5. init qp table
>>
>> Signed-off-by: Wei Hu <xavier.huwei@...wei.com>
>> Signed-off-by: Nenglong Zhao <zhaonenglong@...ilicon.com>
>> Signed-off-by: Lijun Ou <oulijun@...wei.com>
>> ---
> <...>
>
>> +
>> +	ret = hns_roce_bitmap_init(&cq_table->bitmap, hr_dev->caps.num_cqs,
>> +				   hr_dev->caps.num_cqs - 1,
>> +				   hr_dev->caps.reserved_cqs, 0);
>> +	if (ret)
>> +		return ret;
>> +
>> +	return 0;
> You can return directly ret, instead last 4 lines.
Hi, leon
     We have fixed it.
     And Oulijun have sent PATCH V10. Thanks

Regards
Wei Hu
>
>> +}
>> +