linux-kernel - Re: [PATCH V3] clocksource/drivers/tango_xtal: Convert init function to return error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5763F067.5020809@linaro.org>
Date:	Fri, 17 Jun 2016 14:43:19 +0200
From:	Daniel Lezcano <daniel.lezcano@...aro.org>
To:	Marc Gonzalez <marc_gonzalez@...madesigns.com>,
	Thomas Gleixner <tglx@...utronix.de>
Cc:	LKML <linux-kernel@...r.kernel.org>, Mason <slash.tmp@...e.fr>,
	Sebastian Frias <sf84@...oste.net>
Subject: Re: [PATCH V3] clocksource/drivers/tango_xtal: Convert init function
 to return error

On 06/17/2016 02:35 PM, Marc Gonzalez wrote:
> On 17/06/2016 12:26, Daniel Lezcano wrote:
>
>> The init functions do not return any error. They behave as the following:
>>
>>    - panic, thus leading to a kernel crash while another timer may work and
>>         make the system boot up correctly
>>
>>    or
>>
>>    - print an error and let the caller unaware if the state of the system
>                           ^^^                    ^^
> "leave the caller unaware of [...]" (?)
>
>> Change that by converting the init functions to return an error conforming
>> to the CLOCKSOURCE_OF_RET prototype.
>>
>> Proper error handling (rollback, errno value) will be changed later case
>> by case, thus this change just return back an error or success in the init
>                                   ^^^^^^^^^^^
> "just returns an error code from the init function" (?)

Ok, I will do the change when adding the acked-by tag.

[ ... ]

> The code looks good to me.
> Acked-by: Marc Gonzalez <marc_gonzalez@...madesigns.com>
>
> Could you merge, on top of these, the patch we discussed a few weeks ago
> for changing ret to err? (I will attach the patch to this message.)

I don't really mind to convert 'ret' to 'err' if it is your preference 
but can it wait after the changes I initiated ? Much more patches will 
come to consolidate the init functions.



-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog