linux-kernel - Re: [PATCH v7 11/11] serial: 8250_lpss: enable DMA on Intel Quark UART

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201606172102.3HqB4ZNs%fengguang.wu@intel.com>
Date:	Fri, 17 Jun 2016 21:46:29 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:	kbuild-all@...org, Bryan O'Donoghue <pure.logic@...us-software.ie>,
	Peter Hurley <peter@...leysoftware.com>,
	linux-serial@...r.kernel.org, Vinod Koul <vinod.koul@...el.com>,
	linux-kernel@...r.kernel.org, dmaengine@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	ismo.puustinen@...el.com,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH v7 11/11] serial: 8250_lpss: enable DMA on Intel Quark
 UART

Hi,

[auto build test WARNING on tty/tty-testing]
[also build test WARNING on v4.7-rc3 next-20160617]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Andy-Shevchenko/serial-8250-split-LPSS-to-8250_lpss-enable-DMA-on-Quark/20160617-204834
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   drivers/tty/serial/8250/8250_lpss.c: In function 'qrk_serial_exit_dma':
>> drivers/tty/serial/8250/8250_lpss.c:202:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     struct dw_dma_slave *param = &lpss->dma_param;
     ^~~~~~

vim +202 drivers/tty/serial/8250/8250_lpss.c

   186		/* Special DMA address for UART */
   187		dma->rx_dma_addr = 0xfffff000;
   188		dma->tx_dma_addr = 0xfffff000;
   189	
   190		param->dma_dev = &pdev->dev;
   191		param->src_id = 0;
   192		param->dst_id = 1;
   193		param->hs_polarity = true;
   194	
   195		lpss->dma_maxburst = 8;
   196		return 0;
   197	}
   198	
   199	static void qrk_serial_exit_dma(struct lpss8250 *lpss)
   200	{
   201		qrk_serial_exit_dma(lpss);
 > 202		struct dw_dma_slave *param = &lpss->dma_param;
   203	
   204		if (!param->dma_dev)
   205			return;
   206		dw_dma_remove(&lpss->dma_chip);
   207	}
   208	#else	/* CONFIG_SERIAL_8250_DMA */
   209	static int qrk_serial_setup_dma(struct lpss8250 *lpss, struct uart_port *port)
   210	{

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (54753 bytes)