linux-kernel - Re: [PATCH v2 3/8] coccicheck: add indexing enhancement options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1606171729370.3164@hadrien>
Date:	Fri, 17 Jun 2016 17:29:49 +0200 (CEST)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	"Luis R. Rodriguez" <mcgrof@...nel.org>
cc:	Julia Lawall <julia.lawall@...6.fr>, Gilles.Muller@...6.fr,
	nicolas.palix@...g.fr, mmarek@...e.com,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	gregkh@...uxfoundation.org, markivx@...eaurora.org,
	stephen.boyd@...aro.org, zohar@...ux.vnet.ibm.com,
	broonie@...nel.org, ming.lei@...onical.com, tiwai@...e.de,
	johannes@...solutions.net, chunkeey@...glemail.com,
	hauke@...ke-m.de, jwboyer@...oraproject.org,
	dmitry.torokhov@...il.com, dwmw2@...radead.org, jslaby@...e.com,
	torvalds@...ux-foundation.org, cocci@...teme.lip6.fr
Subject: Re: [PATCH v2 3/8] coccicheck: add indexing enhancement options

On Fri, 17 Jun 2016, Luis R. Rodriguez wrote:

> On Fri, Jun 17, 2016 at 11:47:25AM +0200, Julia Lawall wrote:
> >
> >
> > On Thu, 16 Jun 2016, Luis R. Rodriguez wrote:
> >
> > > Coccinelle has support to make use of its own enhanced "grep"
> > > mechanisms instead of using regular grep for searching code,
> > > it calls this 'coccigrep'. In lack of any indexing optimization
> > > information it uses --use-coccigrep by default.
> > >
> > > This patch enable indexing optimizations heuristics so that coccigrep
> > > can automatically detect what indexing options are available and use
> > > them accordinly without any user input.
> > >
> > > Since git has its own index, support for using 'git grep' has been
> > > added to Coccinelle, that should on average perform better than
> > > using the internal coccigrep. Coccinelle has had idutils support
> > > as well for a while now, you however need to refer to the index
> > > file. We support detecting two idutils index files by default,
> > > ID and .id-utils.index, assuming you ran either of:
> > >
> > >  # What you might have done:
> > > mkid -s
> > >  # as in coccinelle scripts/idutils_index.sh
> > > mkid -i C --output .id-utils.index *
> > >
> > > Lastly, Coccinelle has had support for glimpseindex for a long while,
> > > however the glimpseindex tool, the agrep library were previously closed
> > > source, its all now open sourced, and provides the best performance, so
> > > support that if we can detect you have a glimpse index.
> > >
> > > You can always override the index as follows:
> > >
> > > $ make coccicheck V=1 MODE=report COCCI_INDEX="--use-idutils ID"
> >
> > Why not just have a generic COCCI_ARGS argument?
>
> Actually SPFLAGS exists already so we can just document to
> override using that. Will fix.

That seems like a good solution.

julia