linux-kernel - Re: [PATCH V2 45/63] clocksource/drivers/timer-keystone: Convert init function to return error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d8c2943e-8181-c86b-49e7-1a3f473e6407@oracle.com>
Date:	Fri, 17 Jun 2016 09:03:36 -0700
From:	Santosh Shilimkar <santosh.shilimkar@...cle.com>
To:	Daniel Lezcano <daniel.lezcano@...aro.org>, tglx@...utronix.de
Cc:	linux-kernel@...r.kernel.org,
	Santosh Shilimkar <ssantosh@...nel.org>,
	"moderated list:ARM/TEXAS INSTRUM..." 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH V2 45/63] clocksource/drivers/timer-keystone: Convert init
 function to return error

On 6/16/2016 2:27 PM, Daniel Lezcano wrote:
> The init functions do not return any error. They behave as the following:
>
>   - panic, thus leading to a kernel crash while another timer may work and
>        make the system boot up correctly
>
>   or
>
>   - print an error and let the caller unaware if the state of the system
>
> Change that by converting the init functions to return an error conforming
> to the CLOCKSOURCE_OF_RET prototype.
>
> Proper error handling (rollback, errno value) will be changed later case
> by case, thus this change just return back an error or success in the init
> function.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
> ---
>  drivers/clocksource/timer-keystone.c | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
>
Acked-by: Santosh Shilimkar <ssantosh@...nel.org>