linux-kernel - Re: [PATCH] ata: fix "ering" sysfs time printing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160617161053.GK3262@mtj.duckdns.org>
Date:	Fri, 17 Jun 2016 12:10:53 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	y2038@...ts.linaro.org, linux-ide@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	bcm-kernel-feedback-list@...adcom.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ata: fix "ering" sysfs time printing

On Fri, Jun 17, 2016 at 05:37:12PM +0200, Arnd Bergmann wrote:
> The sysfs file for the libata error handling has multiple issues
> in the way it prints time stamps:
> 
>  * it prints a 9-digit nanosecond value using a %06lu format string,
>    which drops some leading zeroes
>  * it converts a 64-bit jiffes value to a timespec using
>    jiffies_to_timespec(), which takes a 'long' argument, so the
>    result is wrong after a jiffies overflow (49 days).
>  * we try to avoid using timespec because that generally overflows
>    in 2038, although this particular usage is ok.
> 
> This replaces the jiffies_to_timespec call with an open-coded
> implementation that gets it right.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Heh, I'm not even sure why we're exposing this but it's already there.
Applied to libata/for-4.8.

Thanks!

-- 
tejun