linux-kernel - Re: [PATCH v3] tracing: expose current->comm to [ku]probe events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160617175251.GB28716@vader.DHCP.thefacebook.com>
Date:	Fri, 17 Jun 2016 10:52:51 -0700
From:	Omar Sandoval <osandov@...ndov.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Masami Hiramatsu <mhiramat@...nel.org>,
	Ingo Molnar <mingo@...hat.com>,
	Namhyung Kim <namhyung@...il.com>,
	linux-kernel@...r.kernel.org, kernel-team@...com,
	Alexei Starovoitov <ast@...com>
Subject: Re: [PATCH v3] tracing: expose current->comm to [ku]probe events

On Fri, Jun 17, 2016 at 12:19:27PM -0400, Steven Rostedt wrote:
> On Thu, 9 Jun 2016 11:55:34 +0900
> Masami Hiramatsu <mhiramat@...nel.org> wrote:
> 
> > On Wed,  8 Jun 2016 18:38:02 -0700
> > Omar Sandoval <osandov@...ndov.com> wrote:
> > 
> > > From: Omar Sandoval <osandov@...com>
> > > 
> > > ftrace is very quick to give up on saving the task command line (see
> > > `trace_save_cmdline()`). The workaround for events which really care
> > > about the command line is to explicitly assign it as part of the entry.
> > > However, this doesn't work for kprobe events, as there's no
> > > straightforward way to get access to current->comm. Add a kprobe/uprobe
> > > event variable $comm which provides exactly that.
> > > 
> > > Signed-off-by: Omar Sandoval <osandov@...com>  
> > 
> > Looks good to me:)
> > 
> > Acked-by: Masami Hiramatsu <mhiramat@...nel.org>
> > 
> > > ---
> > > Alexei pointed out to me that this same functionality can be acheived
> > > with BPF and the bpf_get_current_comm() helper, so strictly speaking,
> > > this patch isn't necessary. It's still convenient for ad-hoc stuff,
> > > though, so I figured I'd throw this up and see what everyone thought.  
> > 
> > Anyway, I'd like to pull this patch since this still be useful
> > in handy way to get comm on ftrace :)
> > 
> 
> I pulled it.
> 
> Thanks!
> 
> -- Steve

Thanks, Steve!

-- 
Omar