linux-kernel - Re: [PATCH 1/3] mm: Don't blindly assign fallback_migrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160617182751.GB692@dhcp22.suse.cz>
Date:	Fri, 17 Jun 2016 20:27:51 +0200
From:	Michal Hocko <mhocko@...nel.org>
To:	Richard Weinberger <richard@....at>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org,
	hannes@...xchg.org, mgorman@...hsingularity.net,
	n-horiguchi@...jp.nec.com, kirill.shutemov@...ux.intel.com,
	hughd@...gle.com, vbabka@...e.cz, adrian.hunter@...el.com,
	dedekind1@...il.com, hch@...radead.org,
	linux-fsdevel@...r.kernel.org, boris.brezillon@...e-electrons.com,
	maxime.ripard@...e-electrons.com, david@...ma-star.at,
	david@...morbit.com, alex@...tthing.co, sasha.levin@...cle.com,
	iamjoonsoo.kim@....com, rvaswani@...eaurora.org,
	tony.luck@...el.com, shailendra.capricorn@...il.com
Subject: Re: [PATCH 1/3] mm: Don't blindly assign fallback_migrate_page()

On Fri 17-06-16 18:55:45, Richard Weinberger wrote:
> Am 17.06.2016 um 18:28 schrieb Michal Hocko:
> > But doesn't this disable the page migration and so potentially reduce
> > the compaction success rate for the large pile of filesystems? Without
> > any hint about that?
> 
> The WARN_ON_ONCE() is the hint. ;)

Right. My reply turned a different way than I meant... I meant to say
that there might be different regressions caused by this change without much
hint that a particular warning would be the smoking gun... 
-- 
Michal Hocko
SUSE Labs