linux-kernel - Re: [PATCH v2] lib: Make strreplace prototype compatible with C++

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57644395.9010505@infradead.org>
Date:	Fri, 17 Jun 2016 11:38:13 -0700
From:	Randy Dunlap <rdunlap@...radead.org>
To:	Matt Ullman <staticfox@...ticfox.net>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] lib: Make strreplace prototype compatible with C++

On 06/17/16 10:24, Matt Ullman wrote:
> Since "new" is a keyword in C++, this breaks compilation when string.h
> is included in a C++ file. For example, this affects VirtualBox Guest
> Additions.
> 
> https://www.virtualbox.org/pipermail/vbox-dev/2015-August/013368.html
> 
> Signed-off-by: Matt Ullman <staticfox@...ticfox.net>
> ---
> Thanks for your feedback and I agree. I've made the requested changes.

I didn't see and could not find any reply to v1.  Who is that comment
addressed to?  Linus?

fwiw, I prefer v1 of the patch.  and so does scripts/kernel-doc.


>  include/linux/string.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/string.h b/include/linux/string.h
> index 26b6f6a..1e5183b 100644
> --- a/include/linux/string.h
> +++ b/include/linux/string.h
> @@ -115,7 +115,7 @@ extern int memcmp(const void *,const void *,__kernel_size_t);
>  extern void * memchr(const void *,int,__kernel_size_t);
>  #endif
>  void *memchr_inv(const void *s, int c, size_t n);
> -char *strreplace(char *s, char old, char new);
> +char *strreplace(char *, char, char);
>  
>  extern void kfree_const(const void *x);
>  
> 


-- 
~Randy