linux-kernel - Re: [PATCH -next] ASoC: cs53l30: Fix non static symbol warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D389B11E.14C8F%Paul.Handrigan@cirrus.com>
Date:	Fri, 17 Jun 2016 18:53:03 +0000
From:	"Handrigan, Paul" <Paul.Handrigan@...rus.com>
To:	"weiyj_lk@....com" <weiyj_lk@....com>,
	"Austin, Brian" <Brian.Austin@...rus.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
CC:	Wei Yongjun <yongjun_wei@...ndmicro.com.cn>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] ASoC: cs53l30: Fix non static symbol warnings



On 6/17/16, 12:22 PM, "weiyj_lk@....com" <weiyj_lk@....com> wrote:

>From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
>
>Fixes the following sparse warnings:
>
>sound/soc/codecs/cs53l30.c:182:20: warning:
> symbol 'input1_sel_values' was not declared. Should it be static?
>sound/soc/codecs/cs53l30.c:202:20: warning:
> symbol 'input2_sel_values' was not declared. Should it be static?
>sound/soc/codecs/cs53l30.c:734:20: warning:
> symbol 'cs53l30_src_rates' was not declared. Should it be static?
>
>Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
>---
> sound/soc/codecs/cs53l30.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/sound/soc/codecs/cs53l30.c b/sound/soc/codecs/cs53l30.c
>index 714e579..a9949ad 100644
>--- a/sound/soc/codecs/cs53l30.c
>+++ b/sound/soc/codecs/cs53l30.c
>@@ -179,7 +179,7 @@ static const char * const input1_sel_text[] = {
> 	"DMIC1 Off ADC1 Off",
> };
> 
>-unsigned int const input1_sel_values[] = {
>+static unsigned int const input1_sel_values[] = {
> 	CS53L30_CH_TYPE,
> 	CS53L30_ADCxB_PDN | CS53L30_CH_TYPE,
> 	CS53L30_ADCxA_PDN | CS53L30_CH_TYPE,
>@@ -199,7 +199,7 @@ static const char * const input2_sel_text[] = {
> 	"DMIC2 Off ADC2 Off",
> };
> 
>-unsigned int const input2_sel_values[] = {
>+static unsigned int const input2_sel_values[] = {
> 	0x0,
> 	CS53L30_ADCxB_PDN,
> 	CS53L30_ADCxA_PDN,
>@@ -731,7 +731,7 @@ static int cs53l30_set_tristate(struct snd_soc_dai
>*dai, int tristate)
> 				  CS53L30_ASP_3ST_MASK, val);
> }
> 
>-unsigned int const cs53l30_src_rates[] = {
>+static unsigned int const cs53l30_src_rates[] = {
> 	8000, 11025, 12000, 16000, 22050, 24000, 32000, 44100, 48000
> };

Acked-by: Paul Handrigan <Paul.Handrigan@...rus.com>