linux-kernel - Re: [PATCH v2] lib: Make strreplace prototype compatible with C++

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1466193295.19647.118.camel@perches.com>
Date:	Fri, 17 Jun 2016 12:54:55 -0700
From:	Joe Perches <joe@...ches.com>
To:	57644395.9010505@...radead.org,
	Randy Dunlap <rdunlap@...radead.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Matt Ullman <staticfox@...ticfox.net>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] lib: Make strreplace prototype compatible with C++

(Matt, you've got an unusual reply-to header)

On Fri, 2016-06-17 at 15:38 -0400, Matt Ullman wrote:
> On Fri, Jun 17, 2016 at 11:38:13AM -0700, Randy Dunlap wrote:
> > I didn't see and could not find any reply to v1.  Who is that comment
> > addressed to?  Linus?
> Yes, this was addressed to Linus. He CC'd the mailing list, but I could not
> find it either. Here is what he wrote:
> > 
> > Please only change the prototype, not the function. Might as well remove
> > the argument names in the prototype.
> > 
> > Let's not make the C code uglier for no reason. The fact that C++ screwed
> > up and thought that "new" can't be used as a variable name is no reason not
> > to do it in C code.
> > 
> > Similarly, we don't make C code use the insane C++ pointer caring rules.
> > 
> >    Linus
> -- Matt Ullman

I think kernel-doc is useful and maybe from/to or find/replace
could be used instead of old/new