linux-kernel - Re: [PATCH] timekeeping: Fix 1ns/tick drift with GENERIC_TIME_VSYSCALL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALAqxLUpG=T4sRtyKbHs2=ZEzRp-SrphO+arBgLi7WHEB+NXcQ@mail.gmail.com>
Date:	Fri, 17 Jun 2016 13:55:17 -0700
From:	John Stultz <john.stultz@...aro.org>
To:	Thomas Graziadei <thomas.graziadei@...cronenergy.com>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] timekeeping: Fix 1ns/tick drift with GENERIC_TIME_VSYSCALL_OLD

On Tue, May 31, 2016 at 6:06 AM, Thomas Graziadei
<thomas.graziadei@...cronenergy.com> wrote:
> From: Thomas Graziadei <thomas.graziadei@...cronenergy.com>
>
> The user notices the problem in a raw and real time drift, calling
> clock_gettime with CLOCK_REALTIME / CLOCK_MONOTONIC_RAW on a system
> with no ntp correction taking place (no ntpd or ptp stuff running).
>
> The problem is, that old_vsyscall_fixup adds an extra 1ns even though
> xtime_nsec is already held in full nsecs and the remainder in this
> case is 0. Do the rounding up buisness only if needed.
>
> Signed-off-by: Thomas Graziadei <thomas.graziadei@...cronenergy.com>

I went ahead and queued this, but I'd still like to see the powerpc
and ia64 maintainers migrate off of the old vsyscall methods.

thanks
-john