linux-kernel - Re: [PATCH 2/6] hid: intel_ish-hid: ISH Transport layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 17 Jun 2016 14:09:05 -0700
From:	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
To:	Jiri Kosina <jikos@...nel.org>
Cc:	jic23@...nel.org, benjamin.tissoires@...hat.com,
	linux-input@...r.kernel.org, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org, chaya.golan@...el.com,
	daniel.drubin@...el.com, A.Bhattacharya@....ac.be
Subject: Re: [PATCH 2/6] hid: intel_ish-hid: ISH Transport layer

On Fri, 2016-06-17 at 22:45 +0200, Jiri Kosina wrote:
> On Fri, 17 Jun 2016, Jiri Kosina wrote:
> 
> > > +struct ishtp_cl_device *ishtp_bus_add_device(struct ishtp_device
> *dev,
> > > +                                        uuid_le uuid, char
> *name)
> > > +{
> > 
> > Should be static.
> 
> Actually, going deeper into the code and trying to untangle all the 
> dependencies, there are quite a few more in other ipc.c, hid-
> client.c, 
> etc. Please fix that globally in the next iteration.
> 
Great. I ran sparse and identified few more. I will fix this is new
iteration.

One thing I am still wondering is that the current ISH model is built
in only. Some distros configure CONFIG_HID as module. So in Kconfig in 
drivers/hid/intel-ish-hid/, I need to add "select HID".
What do you think about this?

Unless you are in middle of review, I want to go ahead and send v2.


Thanks,
Srinivas

> Thanks,
> 
> -- 
> Jiri Kosina
> SUSE Labs
>