linux-kernel - Re: [PATCH 0/4] ASoC: tpa6130a2: Add support for multiple instances

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160618104038.GB31665@earth>
Date:	Sat, 18 Jun 2016 12:40:38 +0200
From:	Sebastian Reichel <sre@...nel.org>
To:	Helen Koike <helen.koike@...labora.co.uk>
Cc:	lgirdwood@...il.com, broonie@...nel.org, peter.ujfalusi@...com,
	jarkko.nikula@...mer.com, lars@...afoo.de, k.kozlowski@...sung.com,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	linux-omap@...r.kernel.org, perex@...ex.cz, tiwai@...e.com
Subject: Re: [PATCH 0/4] ASoC: tpa6130a2: Add support for multiple instances

Hi,

On Sat, Jun 18, 2016 at 12:26:27AM -0300, Helen Koike wrote:
> The current tpa6130a2 driver supports only a single instance.
> This patch series add support for multiple instances by removing
> the global variable that holds the instance. This is performed by
> using the component API, regmap, the snd_soc_{info,put,get}_volsw
> API and DAPM.

yay! *stroking cleanup of the driver from my todo list*

> This patch series also touches code from the Nokia RX51 which I
> didn't tested (as I am testing the tpa6130a2 in another board, that
> is not upstream). I would appreciate is if someone who possesses
> the Nokia RX51 (n900) could please test the code.

I had a look at the rx51 parts and will test later/tomorrow.
From looking at the source code: You can also remove the
"../codecs/tpa6130a2.h" include from rx51.c.

> This patch series is based on git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
> Available at https://git.collabora.com/cgit/user/koike/linux.git/log/?h=sound/review/tpa6130a2
> 
> Helen Koike (4):
>   ASoC: tpa6130a2: Register component
>   ASoC: tap6130a2: Use regmap
>   ASoC: tpa6130a2: Use snd soc volsw functions
>   ASoC: tpa6130a2: Add DAPM support
> 
>  sound/soc/codecs/tpa6130a2.c | 382 ++++++++++++-------------------------------
>  sound/soc/codecs/tpa6130a2.h |  14 +-
>  sound/soc/omap/rx51.c        |  45 ++---
>  3 files changed, 130 insertions(+), 311 deletions(-)

nice stats :)

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)