lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 18 Jun 2016 13:34:54 +0200 From: Boris Brezillon <boris.brezillon@...e-electrons.com> To: Richard Weinberger <richard@....at> Cc: David Woodhouse <dwmw2@...radead.org>, Brian Norris <computersforpeace@...il.com>, linux-mtd@...ts.infradead.org, Hans de Goede <hdegoede@...hat.com>, linux-kernel@...r.kernel.org, Aleksei Mamlin <mamlinav@...il.com> Subject: Re: [PATCH v2 05/15] mtd: nand: add manufacturer specific initialization/detection steps On Sat, 18 Jun 2016 11:23:01 +0200 Richard Weinberger <richard@....at> wrote: > diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c > index 55f3ab8..aadebe7 100644 > --- a/drivers/mtd/nand/nand_base.c > +++ b/drivers/mtd/nand/nand_base.c > @@ -3703,6 +3703,10 @@ static int nand_detect(struct nand_chip *chip, struct nand_flash_dev *type) > > chip->manufacturer.ops = nand_manuf_ids[maf_idx].ops; > > + if (!chip->manufacturer.ops) > + /* assign no operations */ > + chip->manufacturer.ops = nand_manuf_ids[0].ops; > + BTW, this is wrong, the manufacturer id code is not the index of the nand_manuf_ids[] table ;). If we go for this option, we should probably declare no_ops in nand_base.c and assign it here: chip->manufacturer.ops = nand_manuf_no_ops; > if (!type) > type = nand_flash_ids; >
Powered by blists - more mailing lists