lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Sat, 18 Jun 2016 23:35:15 +0900
From:	Tomasz Figa <tomasz.figa@...il.com>
To:	Krzysztof Kozlowski <krzk@...nel.org>
Cc:	Sylwester Nawrocki <s.nawrocki@...sung.com>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...eaurora.org>,
	Kukjin Kim <kgene@...nel.org>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>, linux-clk@...r.kernel.org,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Javier Martinez Canillas <javier@....samsung.com>
Subject: Re: [PATCH v2] clk: samsung: Remove useless check for return value of samsung_clk_init

Hi,

2016-05-10 2:32 GMT+09:00 Krzysztof Kozlowski <krzk@...nel.org>:
> The samsung_clk_init() cannot return NULL. Either it returns allocated
> memory or it panics.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> Reviewed-by: Javier Martinez Canillas <javier@....samsung.com>
>
> ---
>
> Changes since v1:
> 1. Remove the check from most of other Samsung clock drivers (suggested
>    by Javier).
> ---
>  drivers/clk/samsung/clk-exynos4.c    | 2 --
>  drivers/clk/samsung/clk-exynos5250.c | 3 +--
>  drivers/clk/samsung/clk-exynos5420.c | 2 --
>  drivers/clk/samsung/clk-exynos5440.c | 2 --
>  drivers/clk/samsung/clk-s3c2410.c    | 2 --
>  drivers/clk/samsung/clk-s3c2412.c    | 2 --
>  drivers/clk/samsung/clk-s3c2443.c    | 2 --
>  drivers/clk/samsung/clk-s3c64xx.c    | 2 --
>  drivers/clk/samsung/clk-s5pv210.c    | 2 --
>  9 files changed, 1 insertion(+), 18 deletions(-)

Acked-by: Tomasz Figa <tomasz.figa@...il.com>

Best regards,
Tomasz

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ