lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Sat, 18 Jun 2016 23:37:31 +0900
From:	Tomasz Figa <>
To:	Krzysztof Kozlowski <>
Cc:	Sylwester Nawrocki <>,
	Michael Turquette <>,
	Stephen Boyd <>,
	Kukjin Kim <>,
	linux-arm-kernel <>,
	linux-kernel <>,
	Bartlomiej Zolnierkiewicz <>,
	Marek Szyprowski <>
Subject: Re: [PATCH] clk: samsung: Suppress unbinding to prevent theoretical attacks


2016-05-17 16:26 GMT+09:00 Krzysztof Kozlowski <>:
> Although unbinding a driver requires root privileges but it still might
> be used theoretically in certain attacks (by triggering NULL pointer
> exception or memory corruption if driver does not provide proper remove
> callbacks or core does not handle it).
> Samsung clock drivers are essential for system operation so their
> removal is not expected. More over, the Exynos3250 ISP clock driver does
> not implement remove() driver callback and it is not buildable as
> modules.
> Suppress the unbind interface for Exynos3250 ISP and S3C2410 DCLK clock
> drivers.
> Suggested-by: Marek Szyprowski <>
> Cc: Marek Szyprowski <>
> Signed-off-by: Krzysztof Kozlowski <>
> ---
>  drivers/clk/samsung/clk-exynos3250.c   | 1 +
>  drivers/clk/samsung/clk-s3c2410-dclk.c | 5 +++--
>  2 files changed, 4 insertions(+), 2 deletions(-)

Makes sense. (By the way, I wonder if we ever see a solution for the
unbind problem with .remove implemented and some resources that can't
be released at the time .unbind is attempted...)

Acked-by: Tomasz Figa <>

Best regards,

Powered by blists - more mailing lists