linux-kernel - Re: [PATCH v3 1/2] media: Driver for Toshiba et8ek8 5MP sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201606181811.10233@pali>
Date:	Sat, 18 Jun 2016 18:11:10 +0200
From:	Pali Rohár <pali.rohar@...il.com>
To:	Pavel Machek <pavel@....cz>, sakari.ailus@....fi
Cc:	Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>, sre@...nel.org,
	linux-media@...r.kernel.org, robh+dt@...nel.org,
	pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	mchehab@....samsung.com, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] media: Driver for Toshiba et8ek8 5MP sensor

On Saturday 18 June 2016 18:04:23 Pavel Machek wrote:
> Hi!
> 
> > > > +	.reglist = {
> > > > +		{ .ptr = &mode1_poweron_mode2_16vga_2592x1968_12_07fps },
> > > > +		{ .ptr = &mode1_16vga_2592x1968_13_12fps_dpcm10_8 },
> > > > +		{ .ptr = &mode3_4vga_1296x984_29_99fps_dpcm10_8 },
> > > > +		{ .ptr = &mode4_svga_864x656_29_88fps },
> > > > +		{ .ptr = &mode5_vga_648x492_29_93fps },
> > > > +		{ .ptr = &mode2_16vga_2592x1968_3_99fps },
> > > > +		{ .ptr = &mode_648x492_5fps },
> > > > +		{ .ptr = &mode3_4vga_1296x984_5fps },
> > > > +		{ .ptr = &mode_4vga_1296x984_25fps_dpcm10_8 },
> > > > +		{ .ptr = 0 }
> > > > +	}
> > > > +};
> > > 
> > > I'd say .ptr = NULL.
> > 
> > Anyway, this code was generated from configuration ini files and
> > perl script available from:
> > https://gitorious.org/omap3camera/camera-firmware
> > 
> > Originally in Maemo above C structure is compiled into binary file
> > and via request_firmware() loaded from userspace to kernel driver.
> > 
> > For me this sounds like a big overkill, so I included above reglist
> > code direcly into et8ek8 kernel driver to avoid request_firmware()
> > and separate userspace storage...
> 
> Yep, that makes sense, thanks for explanation. I guess that means
> that we should put a comment on top of the file explaining what is
> going on.
> 
> Best regards,
> 									Pavel

Here is that original stingraytsb_v14_simple.ini file:

https://gitorious.org/omap3camera/camera-firmware?p=omap3camera:camera-firmware.git;a=tree;f=ini

Looks like are are some "non simple" stingraytsb_v14 files too, but I
have no idea which modes defines...

Sakari, any idea?
Which we should include into kernel et8ek8 kernel driver?

-- 
Pali Rohár
pali.rohar@...il.com

Download attachment "signature.asc " of type "application/pgp-signature" (199 bytes)