linux-kernel - Re: [PATCH] staging: esp8089: add new driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sun, 19 Jun 2016 20:06:03 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Icenowy Zheng <icenowy@...look.com>
Cc:	kbuild-all@...org, gregkh@...uxfoundation.org,
	devel@...verdev.osuosl.org, Icenowy Zheng <icenowy@...look.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: esp8089: add new driver

Hi,

[auto build test WARNING on staging/staging-testing]
[also build test WARNING on v4.7-rc3 next-20160617]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Icenowy-Zheng/staging-esp8089-add-new-driver/20160619-182134
config: i386-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   In file included from arch/x86/include/asm/string.h:2:0,
                    from include/linux/string.h:18,
                    from arch/x86/include/asm/page_32.h:34,
                    from arch/x86/include/asm/page.h:13,
                    from arch/x86/include/asm/thread_info.h:11,
                    from include/linux/thread_info.h:54,
                    from arch/x86/include/asm/preempt.h:6,
                    from include/linux/preempt.h:59,
                    from include/linux/spinlock.h:50,
                    from include/linux/mm_types.h:8,
                    from include/linux/kmemcheck.h:4,
                    from include/linux/skbuff.h:18,
                    from include/linux/if_ether.h:23,
                    from include/linux/etherdevice.h:25,
                    from drivers/staging/esp8089/esp_mac80211.c:7:
   drivers/staging/esp8089/esp_mac80211.c: In function 'beacon_tim_init':
>> arch/x86/include/asm/string_32.h:325:29: warning: 'memset' used with constant zero length parameter; this could be due to transposed parameters [-Wmemset-transposed-args]
    #define memset(s, c, count) __builtin_memset(s, c, count)
                                ^
>> drivers/staging/esp8089/esp_mac80211.c:325:2: note: in expansion of macro 'memset'
     memset(beacon_tim_saved, BEACON_TIM_SAVE_MAX, 0);
     ^~~~~~
   drivers/staging/esp8089/esp_mac80211.c: At top level:
   drivers/staging/esp8089/esp_mac80211.c:1377:18: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
     .ampdu_action = esp_op_ampdu_action,
                     ^~~~~~~~~~~~~~~~~~~
   drivers/staging/esp8089/esp_mac80211.c:1377:18: note: (near initialization for 'esp_mac80211_ops.ampdu_action')
   cc1: some warnings being treated as errors

vim +/memset +325 drivers/staging/esp8089/esp_mac80211.c

   309		}
   310		epub->vif = NULL;
   311		evif->epub = NULL;
   312	
   313		sip_cmd(epub, SIP_CMD_SETVIF, (u8 *) & svif,
   314			sizeof(struct sip_cmd_setvif));
   315	
   316		/* clean up tx/rx queue */
   317	
   318	}
   319	
   320	#define BEACON_TIM_SAVE_MAX 20
   321	u8 beacon_tim_saved[BEACON_TIM_SAVE_MAX];
   322	int beacon_tim_count;
   323	static void beacon_tim_init(void)
   324	{
 > 325		memset(beacon_tim_saved, BEACON_TIM_SAVE_MAX, 0);
   326		beacon_tim_count = 0;
   327	}
   328	
   329	static u8 beacon_tim_save(u8 this_tim)
   330	{
   331		u8 all_tim = 0;
   332		int i;
   333		beacon_tim_saved[beacon_tim_count] = this_tim;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (55069 bytes)