linux-kernel - Re: [PATCH 1/6] clk: Add missing clk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160620211849.24587.73336@quark.deferred.io>
Date:	Mon, 20 Jun 2016 14:18:49 -0700
From:	Michael Turquette <mturquette@...libre.com>
To:	Daniel Lezcano <daniel.lezcano@...aro.org>,
	daniel.lezcano@...aro.org, tglx@...utronix.de
Cc:	linux-kernel@...r.kernel.org,
	"Russell King" <linux@....linux.org.uk>,
	"open list:CLK API" <linux-clk@...r.kernel.org>
Subject: Re: [PATCH 1/6] clk: Add missing clk_get_sys() stub

Hi Daniel,

Quoting Daniel Lezcano (2016-06-02 14:41:32)
> When compiling with the COMPILE_TEST option set, the clps711x does not
> compile because of the clk_get_sys() noop stub missing.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>

This looks OK to me. Russell maintains clkdev and the clk.h stuff, so it
would be good to get his ack. Please feel free to add:

Reviewed-by: Michael Turquette <mturquette@...libre.com>

Regards,
Mike

> ---
>  include/linux/clk.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/linux/clk.h b/include/linux/clk.h
> index 0df4a51..834179f 100644
> --- a/include/linux/clk.h
> +++ b/include/linux/clk.h
> @@ -461,6 +461,10 @@ static inline struct clk *clk_get_parent(struct clk *clk)
>         return NULL;
>  }
>  
> +static inline struct clk *clk_get_sys(const char *dev_id, const char *con_id)
> +{
> +       return NULL;
> +}
>  #endif
>  
>  /* clk_prepare_enable helps cases using clk_enable in non-atomic context. */
> -- 
> 1.9.1
>