linux-kernel - Re: [PATCH 12/12] leds: Only descend into leds directory when CONFIG_NEW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <57679E38.3080901@samsung.com>
Date:	Mon, 20 Jun 2016 09:41:44 +0200
From:	Jacek Anaszewski <j.anaszewski@...sung.com>
To:	"Andrew F. Davis" <afd@...com>
Cc:	Russell King <linux@...linux.org.uk>,
	Miguel Ojeda Sandonis <miguel.ojeda.sandonis@...il.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Sebastian Reichel <sre@...nel.org>,
	Wolfram Sang <wsa@...-dreams.de>,
	Richard Purdie <rpurdie@...ys.net>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	Lauro Ramos Venancio <lauro.venancio@...nbossa.org>,
	Aloisio Almeida Jr <aloisio.almeida@...nbossa.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Ingo Molnar <mingo@...nel.org>, linux-pwm@...r.kernel.org,
	lguest@...ts.ozlabs.org, linux-wireless@...r.kernel.org,
	linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-gpio@...r.kernel.org, linux-i2c@...r.kernel.org,
	linuxppc-dev@...ts.ozlabs.org, linux-leds@...r.kernel.org,
	linux-media@...r.kernel.org
Subject: Re: [PATCH 12/12] leds: Only descend into leds directory when
 CONFIG_NEW_LEDS is set

On 06/18/2016 12:46 AM, Andrew F. Davis wrote:
> On 06/15/2016 01:48 AM, Jacek Anaszewski wrote:
>> Hi Andrew,
>>
>> Thanks for the patch.
>>
>> Please address the issue [1] raised by test bot and resubmit.
>>
>> Thanks,
>> Jacek Anaszewski
>>
>> [1] https://lkml.org/lkml/2016/6/13/1091
>>
>
> It looks like some systems use 'gpio_led_register_device' to make an
> in-memory copy of their LED device table so the original can be removed
> as .init.rodata. This doesn't necessarily depend on the LED subsystem
> but it kind of seems useless when the rest of the subsystem is disabled.
>
> One solution could be to use a dummy 'gpio_led_register_device' when the
> subsystem is not enabled.

It sounds good. Please add a no-op version of gpio_led_register_device()
to include/leds.h, in a separate patch.

Thanks,
Jacek Anaszewski

> Another is just to remove the five or so uses
> of 'gpio_led_register_device' and have those systems register LED device
> tables like other systems do.
>
> If nether of these are acceptable then this patch can be dropped from
> this series for now.
>
> Thanks,
> Andrew
>
>> On 06/13/2016 10:02 PM, Andrew F. Davis wrote:
>>> When CONFIG_NEW_LEDS is not set make will still descend into the leds
>>> directory but nothing will be built. This produces unneeded build
>>> artifacts and messages in addition to slowing the build. Fix this here.
>>>
>>> Signed-off-by: Andrew F. Davis <afd@...com>
>>> ---
>>>    drivers/Makefile | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/Makefile b/drivers/Makefile
>>> index 567e32c..fa514d5 100644
>>> --- a/drivers/Makefile
>>> +++ b/drivers/Makefile
>>> @@ -127,7 +127,7 @@ obj-$(CONFIG_CPU_FREQ)        += cpufreq/
>>>    obj-$(CONFIG_CPU_IDLE)        += cpuidle/
>>>    obj-$(CONFIG_MMC)        += mmc/
>>>    obj-$(CONFIG_MEMSTICK)        += memstick/
>>> -obj-y                += leds/
>>> +obj-$(CONFIG_NEW_LEDS)        += leds/
>>>    obj-$(CONFIG_INFINIBAND)    += infiniband/
>>>    obj-$(CONFIG_SGI_SN)        += sn/
>>>    obj-y                += firmware/
>>>
>>
>>
>
>