[<prev] [next>] [day] [month] [year] [list]
Message-ID: <1466414900-510-1-git-send-email-chanho.min@lge.com>
Date: Mon, 20 Jun 2016 18:28:20 +0900
From: Chanho Min <chanho.min@....com>
To: <netdev@...r.kernel.org>, "David S. Miller" <davem@...emloft.net>,
Alexey Kuznetsov <kuznet@....inr.ac.ru>,
James Morris <jmorris@...ei.org>
CC: Gunho Lee <gunho.lee@....com>, <linux-kernel@...r.kernel.org>,
Chanho Min <chanho.min@....com>
Subject: [PATCH] ipconfig : Fix null reference to the freed dev_addr
The USB to ethernet can be detached and free netdev after
rtnl mutex is released. It can cause null reference during
the dynamic IP configuration.
sequence is:
ic_open_devs
rtnl_lock();
wait for a carrier
hub_event()
usb_disconnect()
unregister_netdev
rtnl_lock();
rtnl_unlock();
unregister_netdevice
rtnl_unlock();
free_netdev()
ic_dynamic()
another sequence is:
ip_auto_config
ic_dynamic
hub_event
usb_disconnect
free_netdev
ic_bootp_send_if
log:
==========
Unable to handle kernel NULL pointer dereference at virtual address 00000000
pgd = 80004000[ 318.748428] [00000000] *pgd=00000000
Internal error: Oops: 5 [#1] PREEMPT SMP ARM
Modules linked in:[ 318.760356] CPU: 1 PID: 1 Comm: swapper/0
task: b44c8000 ti: b44b2000 task.ti: b44b2000
PC is at mmiocpy+0x8c/0x330
LR is at ip_auto_config+0x70c/0x10a4
==========
To fix this, I suggested patch that checks if device is available
before the DHCP packet is sended.
Signed-off-by: Chanho Min <chanho.min@....com>
---
net/ipv4/ipconfig.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c
index 0bc7412..5b29a32 100644
--- a/net/ipv4/ipconfig.c
+++ b/net/ipv4/ipconfig.c
@@ -1233,6 +1233,10 @@ static int __init ic_dynamic(void)
get_random_bytes(&timeout, sizeof(timeout));
timeout = CONF_BASE_TIMEOUT + (timeout % (unsigned int) CONF_TIMEOUT_RANDOM);
for (;;) {
+ if (d->dev->reg_state != NETREG_REGISTERED) {
+ pr_cont(" lost device!\n");
+ break;
+ }
#ifdef IPCONFIG_BOOTP
/* Track the device we are configuring */
ic_dev_xid = d->xid;
--
1.7.9.5
Powered by blists - more mailing lists