[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-id: <5767DEFB.8010207@samsung.com>
Date: Mon, 20 Jun 2016 14:18:03 +0200
From: Krzysztof Kozlowski <k.kozlowski@...sung.com>
To: Chris Lapa <chris@...a.com.au>, dwmw2@...radead.org,
dbaryshkov@...il.com, sre@...nel.org, mark.rutland@....com,
robh+dt@...nel.org
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-pm@...r.kernel.org
Subject: Re: [PATCH v4 3/7] max8903: cleans up confusing relationship between
dc_valid, dok and dcm.
On 06/20/2016 12:27 AM, Chris Lapa wrote:
> From: Chris Lapa <chris@...a.com.au>
>
> The max8903_charger.h file indicated that dcm and dok were not optional
> when dc_valid is set.
>
> It makes sense to have dok as a compulsory pin when dc_valid is given.
> However dcm can be optionally wired to a fixed level especially when the
> circuit is configured for dc power exclusively.
>
> The previous implementation already allowed for this somewhat, however no
> error was given if dok wasn't given whilst dc_valid was.
>
> The new implementation enforces dok presence when dc_valid is given. Whilst
> allowing dcm to be optional.
>
> Signed-off-by: Chris Lapa <chris@...a.com.au>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
BR.
Krzysztof
Powered by blists - more mailing lists