linux-kernel - Re: [PATCH -next] drm/hisilicon: Fix return value check in ade_dts_parse()

Open Source and information security mailing list archives

Message-ID: <CAGd==07o50ReaNbCeAOH6AZ+zdE5vN4WjJJiJ3ej22LyLaa0bg@mail.gmail.com>
Date:	Mon, 20 Jun 2016 09:56:45 +0800
From:	Xinliang Liu <xinliang.liu@...aro.org>
To:	weiyj_lk@....com
Cc:	Xinliang Liu <z.liuxinliang@...ilicon.com>,
	Xinwei Kong <kong.kongxinwei@...ilicon.com>,
	Chen Feng <puck.chen@...ilicon.com>,
	David Airlie <airlied@...ux.ie>,
	Wei Yongjun <yongjun_wei@...ndmicro.com.cn>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	dri-devel <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH -next] drm/hisilicon: Fix return value check in ade_dts_parse()

Hi,

On 18 June 2016 at 02:29,  <weiyj_lk@....com> wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
>
> In case of error, the function devm_clk_get() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check
> should be replaced with IS_ERR().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>

Applied to drm-hisilicon-next. Thanks.

-xinliang

> ---
>  drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> index ed76baad..16834f4 100644
> --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> @@ -965,21 +965,21 @@ static int ade_dts_parse(struct platform_device *pdev, struct ade_hw_ctx *ctx)
>         }
>
>         ctx->ade_core_clk = devm_clk_get(dev, "clk_ade_core");
> -       if (!ctx->ade_core_clk) {
> +       if (IS_ERR(ctx->ade_core_clk)) {
>                 DRM_ERROR("failed to parse clk ADE_CORE\n");
> -               return -ENODEV;
> +               return PTR_ERR(ctx->ade_core_clk);
>         }
>
>         ctx->media_noc_clk = devm_clk_get(dev, "clk_codec_jpeg");
> -       if (!ctx->media_noc_clk) {
> +       if (IS_ERR(ctx->media_noc_clk)) {
>                 DRM_ERROR("failed to parse clk CODEC_JPEG\n");
> -           return -ENODEV;
> +               return PTR_ERR(ctx->media_noc_clk);
>         }
>
>         ctx->ade_pix_clk = devm_clk_get(dev, "clk_ade_pix");
> -       if (!ctx->ade_pix_clk) {
> +       if (IS_ERR(ctx->ade_pix_clk)) {
>                 DRM_ERROR("failed to parse clk ADE_PIX\n");
> -           return -ENODEV;
> +               return PTR_ERR(ctx->ade_pix_clk);
>         }
>
>         return 0;
>
>
>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives