linux-kernel - Re: [PATCH v3 2/3] block: convert to device_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 20 Jun 2016 07:43:27 -0700
From:	Dan Williams <dan.j.williams@...el.com>
To:	Bart Van Assche <bart.vanassche@...disk.com>
Cc:	linux-block@...r.kernel.org,
	James Bottomley <James.Bottomley@...senpartnership.com>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	Jens Axboe <axboe@...com>,
	"Michael S. Tsirkin" <mst@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Keith Busch <keith.busch@...el.com>,
	"linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>,
	Johannes Thumshirn <jthumshirn@...e.de>,
	Ross Zwisler <ross.zwisler@...ux.intel.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Christoph Hellwig <hch@....de>
Subject: Re: [PATCH v3 2/3] block: convert to device_add_disk()

On Mon, Jun 20, 2016 at 6:33 AM, Bart Van Assche
<bart.vanassche@...disk.com> wrote:
> On 06/17/2016 06:34 PM, Dan Williams wrote:
>>
>> diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c
>> index ef6b4d960bad..4e7cb5df8e43 100644
>> --- a/arch/um/drivers/ubd_kern.c
>> +++ b/arch/um/drivers/ubd_kern.c
>> @@ -823,12 +823,11 @@ static int ubd_disk_register(int major, u64 size,
>> int unit,
>>                 ubd_devs[unit].pdev.dev.release = ubd_device_release;
>>                 dev_set_drvdata(&ubd_devs[unit].pdev.dev,
>> &ubd_devs[unit]);
>>                 platform_device_register(&ubd_devs[unit].pdev);
>> -               disk->driverfs_dev = &ubd_devs[unit].pdev.dev;
>>         }
>>
>>         disk->private_data = &ubd_devs[unit];
>>         disk->queue = ubd_devs[unit].queue;
>> -       add_disk(disk);
>> +       device_add_disk(&ubd_devs[unit].pdev.dev, disk);
>>
>>         *disk_out = disk;
>>         return 0;
>
>
> Have you reviewed this patch yourself? I think the above change is an
> unintended behavior change.

Good catch! You are correct, this driver emits both parented an
un-parented disks.  I'll fix this up and re-check the others.