[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20160620153845.GA11949@sepie.suse.cz>
Date: Mon, 20 Jun 2016 17:38:45 +0200
From: Michal Marek <mmarek@...e.com>
To: Wolfram Sang <wsa@...-dreams.de>
Cc: linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kbuild: setlocalversion: print error to STDERR
On Mon, Jun 06, 2016 at 09:00:38PM +0200, Wolfram Sang wrote:
> I tried to use 'make O=...' from an unclean source tree. This triggered
> the error path of setlocalversion. But by printing to STDOUT, it created
> a broken localversion which then caused another (unrelated) error:
>
> "4.7.0-rc2Error: kernelrelease not valid - run make prepare to update it" exceeds 64 characters
>
> After printing to STDERR, the true build error gets displayed later:
>
> /home/wsa/Kernel/linux is not clean, please run 'make mrproper'
> in the '/home/wsa/Kernel/linux' directory.
>
> Signed-off-by: Wolfram Sang <wsa@...-dreams.de>
> ---
> scripts/setlocalversion | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, applied to kbuild.git#kbuild. But this points at another
problem, namely that filechk is ignoring the exit status of the command.
Michal
Powered by blists - more mailing lists