linux-kernel - Re: [PATCH] ARM: AM43XX: hwmod: Fix RSTST register offset for pruss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5768177B.9070306@ti.com>
Date:	Mon, 20 Jun 2016 11:19:07 -0500
From:	Suman Anna <s-anna@...com>
To:	Keerthy <a0393675@...com>, "Mohammed, Afzal" <afzal@...com>,
	"J, KEERTHY" <j-keerthy@...com>,
	"tony@...mide.com" <tony@...mide.com>
CC:	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Kristo, Tero" <t-kristo@...com>,
	"Gerlach, Dave" <d-gerlach@...com>,
	"paul@...an.com" <paul@...an.com>,
	"linux@...linux.org.uk" <linux@...linux.org.uk>
Subject: Re: [PATCH] ARM: AM43XX: hwmod: Fix RSTST register offset for pruss

Hi Afzal,

On 06/20/2016 03:23 AM, Keerthy wrote:
> 
> 
> On Monday 20 June 2016 12:35 PM, Mohammed, Afzal wrote:
>> Hi,
>>
>> J, KEERTHY wrote on Monday, June 20, 2016 9:22 AM:
>>
>>> pruss hwmod RSTST register wrongly points to PWRSTCTRL register in
>>> case of
>>> am43xx. Fix the RSTST register offset value.
>>
>>> This can lead to setting of wrong power state values for PER domain.
>>
>> Just curious, does it happen or noticed by going thr' the code ?

It does happen when the pruss module is exercised. We found this when we
tried to do a standby test on suspend, and while it worked on AM33xx,
AM437x failed because of this difference.

regards
Suman

> 
> No i was trying omap4_prminst_deassert_hardreset on AM43XX on my local
> tree and i saw issues and then saw that RSTST register offsets were
> wrongly populated. Hence fixing the same.
> 
>>
>> Regards
>> afzal
>>