linux-kernel - Re: [PATCH 2/2] dt-bindings: phy: Add qcom,usb-hsic-phy bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 20 Jun 2016 11:26:22 -0500
From:	Rob Herring <robh@...nel.org>
To:	Neil Armstrong <narmstrong@...libre.com>
Cc:	balbi@...nel.org, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: phy: Add qcom,usb-hsic-phy bindings

On Fri, Jun 17, 2016 at 12:25:19PM +0200, Neil Armstrong wrote:
> Signed-off-by: Neil Armstrong <narmstrong@...libre.com>
> ---
>  .../devicetree/bindings/phy/qcom,usb-hsic-phy.txt  | 95 ++++++++++++++++++++++
>  1 file changed, 95 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/phy/qcom,usb-hsic-phy.txt
> 
> diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-hsic-phy.txt b/Documentation/devicetree/bindings/phy/qcom,usb-hsic-phy.txt
> new file mode 100644
> index 0000000..79259a4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/qcom,usb-hsic-phy.txt
> @@ -0,0 +1,95 @@
> +Qualcomm's MDM9615 USB HISC transceiver controller
> +
> +- compatible:
> +    Usage: required
> +    Value type: <string>
> +    Definition: Should contain "qcom,usb-hsic-phy".

SoC specific compatible string please.

> +
> +- reg:
> +    Usage: required
> +    Value type: <prop-encoded-array>
> +    Definition: USB PHY base address and length of the register map
> +
> +- clocks:
> +    Usage: required
> +    Value type: <prop-encoded-array>
> +    Definition: See clock-bindings.txt section "consumers". List of
> +                5 clock specifiers for interface and core controller
> +                clocks.
> +
> +- clock-names:
> +    Usage: required
> +    Value type: <string>
> +    Definition: Must contain "core", "alt-core", "phy", "cal" and "iface" strings.
> +
> +- vddcx-supply:
> +    Usage: required
> +    Value type: <phandle>
> +    Definition: phandle to the regulator VDCCX supply node.
> +
> +- resets:
> +    Usage: required
> +    Value type: <prop-encoded-array>
> +    Definition: See reset.txt section "consumers". PHY reset specifier.
> +
> +- reset-names:
> +    Usage: required
> +    Value type: <string>
> +    Definition: Must contain "link" string.
> +
> +- interrupts:
> +    Usage: required
> +    Value type: <prop-encoded-array>
> +    Definition: Interrupt line definition for the PHY
> +
> +- dr_mode:
> +    Usage: required
> +    Value type: <prop-encoded-array>
> +    Definition: Setup the PHY mode, either "host", "gadget" or "dual"
> +
> +- qcom,vdd-levels:
> +    Usage: required for MDM9615
> +    Value type: <prop-encoded-array>
> +    Definition: Setup the valid vdd levers for the vddx-supply

s/levers/levels/

There's not a common regulator property for this?

> +
> +- phy_type:
> +    Usage: required
> +    Value type: <prop-encoded-array>
> +    Definition: Shall be "hisc"

typo

> +
> +- qcom,tlmm:
> +    Usage: required for MDM961

s/MDM961/MDM9615/

or drop because this binding is only for MDM9615.

> +    Value type: <prop-encoded-array>
> +    Definition: TLMM syscon phandle to setup the HSIC lines
> +
> +- qcom,tlmm-cfg:
> +    Usage: required for MDM961

s/MDM961/MDM9615/

> +    Value type: <prop-encoded-array>
> +    Definition: Shall be two entries of offset, data of the HSIC lines setup

This property is somewhat questionable with just magic register address 
and value to write...