linux-kernel - Re: Canonical has own Ubuntu driver for ALPS 73 03 28 devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 20 Jun 2016 10:37:57 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Anthony Wong <anthony.wong@...onical.com>
Cc:	Pali Rohár <pali.rohar@...il.com>,
	Christoph Hellwig <hch@...radead.org>,
	Ben Gamari <ben@...rt-cactus.org>,
	Hans de Goede <hdegoede@...hat.com>,
	Allen Hung <Allen_Hung@...l.com>,
	Ben Morgan <Ben_Morgan@...l.com>,
	Masaki Ota <masaki.ota@...alps.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: Canonical has own Ubuntu driver for ALPS 73 03 28 devices

On Tue, Jun 21, 2016 at 01:29:41AM +0800, Anthony Wong wrote:
> On 20 June 2016 at 18:20, Pali Rohár <pali.rohar@...il.com> wrote:
> >
> > On Monday 20 June 2016 03:16:36 Christoph Hellwig wrote:
> > > On Sun, Jun 19, 2016 at 01:43:46AM +0200, Pali Roh??r wrote:
> > > > I do not understand it... Why Canonical is hidden and don't communicate
> > > > with rest of world? Otherwise touchpads could work out-of-box on non
> > > > Ubuntu systems too with mainline kernel.
> > >
> >
> > It must be really frustrating for Ben and other people (me too) who in
> > last months working on ALPS patches to support that touchpad as we know
> > that Canonical already had some working code for that touchpad...
> 
> Hi Pali,
> 
> The fix in the DKMS package you referenced was not written by
> Canonical but by ALPS, as it came from them I think it is reasonable
> they send it to upstream, isn't it? As you can see the patch is non-trivial.
> 
> After we got the patch from ALPS, we had follow-up conversation a few
> times with our contacts at Taiwan and asked if they would upstream it,
> but unfortunately to no avail. I am as desperate as you if the fix
> cannot land in mainline, which means many Linux users will not benefit
> from it.  We also had opened this bug [1] for this particular issue,
> there is nothing to hide. If there is any code written by us, we
> happily submit them upstream.

Why couldn't you guys send it upstream yourselves?

> 
> [1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1571530
> 
> > On Monday 20 June 2016 03:16:36 Christoph Hellwig wrote:
> > > Because Canonical doesn't collaborate with the upstream community
> > > in any meaninful way.  They've been a bad player since day 1 and will
> > > always be.
> 
> This reminded me of this old thread [2]. How hard is it to run this
> command in your kernel git tree?
> 
>     $ git log --pretty=oneline --author=canonical
> 
> [2] https://www.spinics.net/lists/linux-bluetooth/msg47286.html
> 
> Thanks,
> Anthony

-- 
Dmitry