linux-kernel - Re: [PATCH V2 14/63] clocksource/drivers/bcm_kona: Convert init function to return error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57682A76.1070800@linaro.org>
Date:	Mon, 20 Jun 2016 19:40:06 +0200
From:	Daniel Lezcano <daniel.lezcano@...aro.org>
To:	Ray Jui <ray.jui@...adcom.com>, tglx@...utronix.de
Cc:	linux-kernel@...r.kernel.org,
	Florian Fainelli <f.fainelli@...il.com>,
	Ray Jui <rjui@...adcom.com>,
	Scott Branden <sbranden@...adcom.com>,
	"open list:BROADCOM BCM281XX..." 
	<bcm-kernel-feedback-list@...adcom.com>
Subject: Re: [PATCH V2 14/63] clocksource/drivers/bcm_kona: Convert init
 function to return error

On 06/20/2016 07:22 PM, Ray Jui wrote:

[ ... ]

>> -static void __init kona_timer_init(struct device_node *node)
>> +static int __init kona_timer_init(struct device_node *node)
>>  {
>>      u32 freq;
>>      struct clk *external_clk;
>>
>>      if (!of_device_is_available(node)) {
>>          pr_info("Kona Timer v1 marked as disabled in device tree\n");
>> -        return;
>> +        return 0;
>
> I thought we should return -ENODEV here.
>
> Moreover, if this device node is not enabled, kona_timer_init won't even
> be invoked. Can we simply get rid of this check here?

Yes, absolutely :)



-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog