linux-kernel - Re: [PATCH v2] arm: tegra124: remove commas from unit addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160620171124.GA6333@ulmo.ba.sec>
Date:	Mon, 20 Jun 2016 19:11:24 +0200
From:	Thierry Reding <thierry.reding@...il.com>
To:	Stephen Warren <swarren@...dotorg.org>
Cc:	Marcel Ziswiler <marcel.ziswiler@...adex.com>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Rob Herring <robh+dt@...nel.org>, linux-tegra@...r.kernel.org,
	Mark Rutland <mark.rutland@....com>,
	Alexandre Courbot <gnurou@...il.com>,
	Russell King <linux@...linux.org.uk>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2] arm: tegra124: remove commas from unit addresses

On Mon, Jun 20, 2016 at 10:45:55AM -0600, Stephen Warren wrote:
> On 06/20/2016 10:40 AM, Thierry Reding wrote:
> > On Mon, Jun 20, 2016 at 09:50:26AM -0600, Stephen Warren wrote:
> > > On 06/18/2016 07:04 PM, Marcel Ziswiler wrote:
> > > > Remove commas from unit addresses as suggested by Rob Herring upon me
> > > > posting initial Apalis TK1 support:
> > > > 
> > > > http://article.gmane.org/gmane.linux.ports.tegra/26608
> > > 
> > > Acked-by: Stephen Warren <swarren@...dia.com>
> > 
> > I'm confused now. I posted almost exactly the same patch a while ago and
> > we agreed that we couldn't do this because the node names were to be
> > considered part of the ABI.
> > 
> > Is it or is it not?
> 
> The particular case where it matters is the GPU node, which U-Boot
> manipulates. This revised patch version no longer renames the GPU node and
> so in practice avoids any issues that I'm aware of.
> 
> If there's a more general rule that node names are part of the ABI, then
> indeed we shouldn't take this patch.

I'm somewhat uncomfortable with this notion. Just because we don't know
of any other cases doesn't mean there aren't any. My understanding is
that it's fairly common to look up device tree nodes by name, however
brittle that may be.

There's also the matter of consistency to consider here. I suspect that
if we make this change somebody will notice the odd one out and send
patches to "fix it up". So if we get confirmation about this change
being okay, I'd request that a comment be added to the GPU node as to
why it is not converted.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)