[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <5768309C.9020103@arm.com>
Date: Mon, 20 Jun 2016 19:06:20 +0100
From: Sudeep Holla <sudeep.holla@....com>
To: Kevin Hilman <khilman@...libre.com>
Cc: Sudeep Holla <sudeep.holla@....com>, linux-kernel@...r.kernel.org,
linux-pm@...r.kernel.org, Ulf Hansson <ulf.hansson@...aro.org>,
Jon Medhurst <tixy@...aro.org>,
Mathieu Poirier <mathieu.poirier@...aro.org>,
Suzuki K Poulose <suzuki.poulose@....com>,
"Rafael J. Wysocki" <rjw@...ysocki.net>
Subject: Re: [PATCH v2 3/3] firmware: scpi: add device power domain support
using genpd
On 20/06/16 18:53, Kevin Hilman wrote:
> Sudeep Holla <sudeep.holla@....com> writes:
>
>> This patch hooks up the support for device power domain provided by
>> SCPI using the Linux generic power domain infrastructure.
>>
>> Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>
>> Cc: Kevin Hilman <khilman@...nel.org>
>> Cc: Ulf Hansson <ulf.hansson@...aro.org>
>> Cc: linux-pm@...r.kernel.org
>> Signed-off-by: Sudeep Holla <sudeep.holla@....com>
>
> [...]
>
>> +static int scpi_pd_power(struct scpi_pm_domain *pd, bool power_on)
>> +{
>> + int ret;
>> + enum scpi_power_domain_state state;
>> +
>> + if (power_on)
>> + state = SCPI_PD_STATE_ON;
>> + else
>> + state = SCPI_PD_STATE_OFF;
>> +
>> + ret = pd->ops->device_set_power_state(pd->domain, state);
>
> There should probably be some sanity checks here that these function
> pointers are non-NULL.
>
Yes I agree. Since with the current scpi driver, if scpi_ops is
populated, it's all non-NULL I skipped the sanity check as the probe
will check for non-NULL scpi_ops.
However, with extension work by Neil I agree, we may have to revisit all
such callers.
--
Regards,
Sudeep
Powered by blists - more mailing lists