linux-kernel - Re: [PATCH 1/9] regulator: tps65217: Enable suspend configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160621190848.GF28202@sirena.org.uk>
Date:	Tue, 21 Jun 2016 20:08:48 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Keerthy <j-keerthy@...com>
Cc:	tony@...mide.com, devicetree@...r.kernel.org,
	linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org,
	t-kristo@...com, russ.dill@...com, robh+dt@...nel.org,
	mark.rutland@....com, linux@...linux.org.uk
Subject: Re: [PATCH 1/9] regulator: tps65217: Enable suspend configuration

On Mon, Jun 20, 2016 at 02:13:30PM +0530, Keerthy wrote:

> +static struct tps65217_regulator_data regulator_data[TPS65217_NUM_REGULATOR];

Why is this a static global?

> +		/* Store default strobe info */
> +		ret = tps65217_reg_read(tps, regulators[i].bypass_reg, &val);
> +
> +		regulator_data[i].strobe = val & regulators[i].bypass_mask;
> +

Not sure what this is doing...  I think this needs splitting up a bit,
it looks like it's a bit more than just adding the ops (which should be
generic things), that bit seems OK but there's these other bits in
there as well.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)