linux-kernel - Re: [PATCH 1/3] staging: lowmemorykiller: change lowmem_adj to lowmem_score

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1606211326120.28466@chino.kir.corp.google.com>
Date:	Tue, 21 Jun 2016 13:27:40 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Ganesh Mahendran <opensource.ganesh@...il.com>
cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	gregkh@...uxfoundation.org, arve@...roid.com, riandrews@...roid.com
Subject: Re: [PATCH 1/3] staging: lowmemorykiller: change lowmem_adj to
 lowmem_score_adj

On Tue, 21 Jun 2016, Ganesh Mahendran wrote:

> om_adj is deprecated, and in lowmemorykiller module, we use score adj
> to do the comparing.
> ---
>                 oom_score_adj = p->signal->oom_score_adj;
>                 if (oom_score_adj < min_score_adj) {
>                         task_unlock(p);
>                         continue;
>                 }
> ---
> 
> This patch makes the variable name consistent with the usage.
> 

Umm, I don't think you can just remove a parameter to a module and replace 
it with something that has a different unit and not think that userspace 
will break as a result.