linux-kernel - Re: [PATCH] ASoC: cs53l30: Add MUTE pin control support via GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160621213437.GA3571@rob-hp-laptop>
Date:	Tue, 21 Jun 2016 16:34:37 -0500
From:	Rob Herring <robh@...nel.org>
To:	Nicolin Chen <nicoleotsuka@...il.com>
Cc:	broonie@...nel.org, lgirdwood@...il.com, brian.austin@...rus.com,
	Paul.Handrigan@...rus.com, linux-kernel@...r.kernel.org,
	alsa-devel@...a-project.org, devicetree@...r.kernel.org,
	mark.rutland@....com
Subject: Re: [PATCH] ASoC: cs53l30: Add MUTE pin control support via GPIO

On Mon, Jun 20, 2016 at 06:54:44PM -0700, Nicolin Chen wrote:
> The codec chip has a physical MUTE pin to let users control it via
> GPIO. So this patch add a mute control support to the driver.
> 
> Signed-off-by: Nicolin Chen <nicoleotsuka@...il.com>
> ---
>  .../devicetree/bindings/sound/cs53l30.txt          |  2 ++
>  sound/soc/codecs/cs53l30.c                         | 30 ++++++++++++++++++++++
>  sound/soc/codecs/cs53l30.h                         |  1 +
>  3 files changed, 33 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/cs53l30.txt b/Documentation/devicetree/bindings/sound/cs53l30.txt
> index 18d6b99..6f7d3c8 100644
> --- a/Documentation/devicetree/bindings/sound/cs53l30.txt
> +++ b/Documentation/devicetree/bindings/sound/cs53l30.txt
> @@ -13,6 +13,8 @@ Optional properties:
>  
>    - reset-gpios : a GPIO spec for the reset pin.
>  
> +  - mute-gpios : a GPIO spec for the MUTE pin.

Please define the active state for the gpio.

> +
>    - cirrus,micbias-lvl : Set the output voltage level on the MICBIAS Pin.
>  			 0 = Hi-Z
>  			 1 = 1.80 V