linux-kernel - Re: [PATCH v4 0/2] ASoC: da7219: Convert driver to use generic FW functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <6274a042-da99-e3e6-20f2-37ce2651645c@intel.com>
Date:	Wed, 22 Jun 2016 00:30:06 +0200
From:	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
To:	Adam Thomson <Adam.Thomson.Opensource@...semi.com>
Cc:	Robert Moore <robert.moore@...el.com>,
	Lv Zheng <lv.zheng@...el.com>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Len Brown <lenb@...nel.org>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Rob Herring <robh+dt@...nel.org>,
	Frank Rowand <frowand.list@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	linux-acpi <linux-acpi@...r.kernel.org>,
	devicetree <devicetree@...r.kernel.org>,
	alsa-devel <alsa-devel@...a-project.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Support Opensource <support.opensource@...semi.com>,
	Sathyanarayana Nujella <sathyanarayana.nujella@...el.com>
Subject: Re: [PATCH v4 0/2] ASoC: da7219: Convert driver to use generic FW
 functions

On 6/21/2016 7:50 PM, Adam Thomson wrote:
> This patch set converts the da7219 codec driver to use device/fwnode functions
> to access properties, instead of the DT only of_* functions, allowing ACPI
> to be used as well.
>
> The DT bindings for da7219 have a device node for the main codec properties,
> and a named child node (da7219_aad), which contains all of the accessory
> detection related properties for the device. ACPI also supports this kind of
> FW hierarchy (data only sub-nodes), but some support in the kernel needs to be
> added to take make use of this in driver code.
>
> The first patch adds functions to allow searching for a named child node of a
> device, for both DT and ACPI, and the second patch updates the codec driver to
> use the standard device/fwnode calls, including this new function.
>
> These changes are based on the v4.7-rc4 kernel.
>
> Changes in v4:
>   - Rebase to v4.7-rc4
>   - Use strcmp() in acpi_data_node_match() for matching ACPI data nodes.
>
> Changes in v3:
>   - Use of_node_cmp() in device_get_named_child_node() to match DT node.
>
> Changes in v2:
>   - Rebase to v4.7-rc1
>   - Small updates to codec patch based on previous reviewer comments
>
> Adam Thomson (2):
>    device property: Add function to search for named child of device
>    ASoC: da7219: Convert driver to use generic device/fwnode functions
>
>   drivers/base/property.c       |  28 ++++++++++++
>   include/acpi/acpi_bus.h       |   7 +++
>   include/linux/acpi.h          |   6 +++
>   include/linux/of.h            |  14 +++---
>   include/linux/property.h      |   3 ++
>   sound/soc/codecs/da7219-aad.c | 103 +++++++++++++++++++++---------------------
>   sound/soc/codecs/da7219.c     |  34 +++++++-------
>   7 files changed, 119 insertions(+), 76 deletions(-)
>
> --
> 1.9.3
>
I'm fine with the first patch and the second one carries a couple of 
ACKs already, so do you want me to apply them both?