[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHQ1cqE+Y9iQeZ=nqFdNEa15RyARn54RHG8pO6jh7CLRfqBUnQ@mail.gmail.com>
Date: Tue, 21 Jun 2016 16:06:11 -0700
From: Andrey Smirnov <andrew.smirnov@...il.com>
To: Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Cc: rtc-linux@...glegroups.com,
Alessandro Zummo <a.zummo@...ertech.it>,
linux-kernel@...r.kernel.org, Chris Healy <cphealy@...il.com>
Subject: Re: [PATCH v2 13/17] RTC: ds1307: Report oscillator problems more intelligently
On Tue, Jun 21, 2016 at 2:22 PM, Alexandre Belloni
<alexandre.belloni@...e-electrons.com> wrote:
> On 21/06/2016 at 00:22:46 -0700, Andrey Smirnov wrote :
>> Report oscillator problems more intelligently, by printing more
>> information about what cause the issue and not yelling "SET TIME!" at
>> the user.
>>
>
> Well, the proper way of doing that is to ensure that -EINVAL is returned
> when reading the time until it has been set once instead of starting the
> oscillator and forgetting about that useful information.
Agreed, will change in v3.
Powered by blists - more mailing lists